search

contao / manager-bundle

[READ-ONLY] Contao Manager Bundle
GNU Lesser General Public License v3.0
17 stars 10 forks source link

Added command options to define the dev entry point password #33

Closed aschempp closed 7 years ago

aschempp commented 7 years ago

fixes https://github.com/contao/manager-bundle/issues/23

Symfony 3.3 introduced the .env component (http://symfony.com/blog/new-in-symfony-3-3-dotenv-component). The app_dev.php password is always stored there, which has multiple advantages:

  1. @discordier can always use that variable as requested in #23
  2. the file is persistent across multiple composer:update commands (that will re-run contao:install-web-dir and would delete the password
  3. The .env file can be deployed to dev but not to prod
aschempp commented 7 years ago

That is exactly the same discussion we had with the UserPasswordCommand and we decided to add the non-interactive option…

leofeyer commented 7 years ago

Yes, but you are now using --password to enable the dialog and --password=value to provide the password with the command. That's confusing, isn't it?

aschempp commented 7 years ago

That's similar to what different unix tools do, e.g. mysql -p to ask for password or mysql -p foobar to pass the password…

leofeyer commented 7 years ago

Well played. 😄

aschempp commented 7 years ago

We already do? We have basic authentication, the standard does not?

aschempp commented 7 years ago

What are you missing?

leofeyer commented 7 years ago

I'm not missing anything, there is too much in the PR. 😄 Can you please rebase?

leofeyer commented 7 years ago

Never mind. The PR was still targeted against the develop branch.