search

contao / manager-bundle

[READ-ONLY] Contao Manager Bundle
GNU Lesser General Public License v3.0
17 stars 10 forks source link

[RFC] fix interaction of contao:install-web-dir #41

Closed fritzmg closed 7 years ago

fritzmg commented 7 years ago

This fixes #39 and #40. With this change, the command will always ask for the username and password (if not defined with --user=… or --password=…) for the dev entry point - unless the --no-dev argument was provided.

fritzmg commented 7 years ago

Hm, wait, this might break the Contao Manager. After a composer update/install, ScriptHandler::initializeApplication also executes contao:install-web-dir. However, now the command will wait for user entry, if no user name or password has been defined. But I don't think the Contao Manager will be able to provide the interaction?

Also may be the interact method should check whether an .env file actually already exists.

aschempp commented 7 years ago

The password is not necessary if you are on a local environment. The password is optional, and the manager cannot ask for it. The --no-dev option is available to not copy the app_dev.php, so it's three functions in one command.

I'm sorry but I have to close this. We need to fix the password interaction, not change the functionality.