search

contao / manager-bundle

[READ-ONLY] Contao Manager Bundle
GNU Lesser General Public License v3.0
17 stars 10 forks source link

Preview maintenance mode locally #78

Closed m-vo closed 6 years ago

m-vo commented 6 years ago

In 423a6831d9a25c0cfe165f4ef537165aff8a3536 the default configuration for authorized ips (lexik maintenance bundle) has been set to ['127.0.0.1'] as a quick fix for https://github.com/contao/core-bundle/issues/1492.

How am I supposed to test the maintenance mode locally now (e.g. when working on a custom service_unavailable template) besides temporarily removing the setting again in my config like so (with the implications of the referenced ticket)? 

lexik_maintenance:
    authorized:
        ips: []

btw.: The related PR in Symfony https://github.com/symfony/symfony/pull/27309 that was in the way and leaded to the quickfix has been merged in 3.4.12.

leofeyer commented 6 years ago

We can revert the intermediate fix now.

leofeyer commented 6 years ago

Reverted in 5768cfec7aa7b46368d3466e330ca2e1e9e0ee5d.