search

contao / manager-plugin

Contao Manager Plugin
GNU Lesser General Public License v3.0
4 stars 9 forks source link

Automatically add dependencies for legacy modules #2

Closed aschempp closed 7 years ago

aschempp commented 7 years ago

If a module in system/modules does currently not have an autoload.ini, the sorting of dependencies gets wrong because the original core modules no longer exist so the sort-by-name no longer applies.

This PR restores at least the functionality to request sorting before the legacy core modules. Having an autoload.ini would automatically override these defaults.

Open question: If the legacy modules in Contao\ModuleLoader would be a constant instead of a private method, we would not have to re-define these again in the ModuleConfig. I suggest to make that change, it cannot be a BC break.

Toflar commented 7 years ago

If the legacy modules in Contao\ModuleLoader would be a constant instead of a private method, we would not have to re-define these again in the ModuleConfig. I suggest to make that change, it cannot be a BC break.

I don't think that's needed here, really. It's something that's never gonna change so it's not needed to be fetched "dynamically". Just leave it as is, imho.

leofeyer commented 7 years ago

If the legacy modules in Contao\ModuleLoader would be a constant instead of a private method, we would not have to re-define these again in the ModuleConfig. I suggest to make that change, it cannot be a BC break.

I don't think that's needed here, really. It's something that's never gonna change so it's not needed to be fetched "dynamically". Just leave it as is, imho.

I don't care either way. I think @Toflar is right though.

aschempp commented 7 years ago

fine with me :-)