search

contao / manager-plugin

Contao Manager Plugin
GNU Lesser General Public License v3.0
4 stars 9 forks source link

Load artifacts from the project directory #38

Closed aschempp closed 2 years ago

aschempp commented 2 years ago

Our composer plugin automatically registers the ZIP packages (uploads) folder from Contao Manager as a package repository. When running as the Contao Manager, the Composer data-dir is the contao-manager folder. However, this "breaks" when running as a regular composer command. This PR fixes that problem (I know there have been issues reported about it, but I couldn't find them).

aschempp commented 2 years ago

@leofeyer can you please also update the CI chain to check for PHP8.1 and maybe re-run periodically?

leofeyer commented 2 years ago

You can do it yourself by adjusting the .github/workflows/ci.yml file according to your needs. Or do you know that already and just want me to do it? 😄

aschempp commented 2 years ago

You can do it yourself by adjusting the .github/workflows/ci.yml file according to your needs. Or do you know that already and just want me to do it? 😄

I meant according to the contao/contao standard. Looks like the CS fixer is old as well, and maybe we should use a tools directory etc?

leofeyer commented 2 years ago

I will have a look. 👍

leofeyer commented 2 years ago

PR is here: https://github.com/contao/manager-plugin/pull/39 I don't know how to fix the two unit tests, though.