contao / standard-edition

[DEPRECATED] Do not use anymore!
33 stars 8 forks source link

Streamline log files as SF now does #32

Closed Toflar closed 8 years ago

Toflar commented 8 years ago

See http://symfony.com/blog/new-in-symfony-streamlined-log-files

leofeyer commented 8 years ago

We might as well change this in version 4.1.1, don't you think?

Toflar commented 8 years ago

I think, yes.

leofeyer commented 8 years ago

The following configuration works best for me:

monolog:
    handlers:
        main:
            type:      rotating_file
            max_files: 10
            path:      "%kernel.logs_dir%/%kernel.environment%.log"
            level:     debug
            channels:  [!doctrine, !event, !php]

Since we are still using scopes, the log file was cluttered with deprecation warnings, which is why I have added !php.

leofeyer commented 8 years ago

Changed in 17cf1c1262281fb5c613c31e86673bb194edf2ec.

Toflar commented 8 years ago

I don't think we should not log deprecation notices in the dev environment. It's the wrong approach, we must remove the scopes instead!

leofeyer commented 8 years ago

Of course. Still please note that the deprecation notices will still be shown in the web profiler. They are just not being logged anymore. Also, we are talking about hundreds of lines for each request!

aschempp commented 8 years ago

Are we not using the fingers_crossed handler?

leofeyer commented 8 years ago

Only in production (which is the Symfony default IMHO).