search

contao / standard-edition

[DEPRECATED] Do not use anymore!
33 stars 8 forks source link

cacheWarmup for "setup-scripts" #68

Closed rabauss closed 7 years ago

rabauss commented 7 years ago

the contao cache is not recreated with composer update/install (cache:clear without --no-warmup is deprecated since symfony 3.3)

so there should be added a script for warmup in the "setup-scripts" of composer.json!

see also: https://github.com/contao/installation-bundle/issues/63

Toflar commented 7 years ago

The managed edition does already do that. The standard edition does not provide any automated behavior whatsoever.

leofeyer commented 7 years ago

It seems that Symfony has not adjusted to the new behavior either:

https://github.com/symfony/symfony-standard/blob/3.3/composer.json#L37

https://github.com/sensiolabs/SensioDistributionBundle/blob/master/Composer/ScriptHandler.php

There should be one clearCache() method and one warmCache() method IMO.

aschempp commented 7 years ago

That actually a Symfony/SensioLabs issue, right?

leofeyer commented 7 years ago

Kind of, yes.

leofeyer commented 7 years ago

The managed edition does already do that. The standard edition does not provide any automated behavior whatsoever.

As discussed in Mumble on August 10th, 2017, we will not add a separate script handler to the standard edition unless Symfony does so as well.