Add compatibility with PHP 8.0

contao / tcpdf-bundle

Article to PDF bundle for Contao 4

0 stars 2 forks source link

Add compatibility with PHP 8.0 #1

Closed ausi closed 3 years ago

ausi commented 3 years ago

How do we test if it is actually compatible?

leofeyer commented 3 years ago

Our code is quite straightforward and should not cause issues. However, tecnickcom/tcpdf is not yet compatible with PHP 8 and nobody knows if and when it will be. There are even speculations that the project has been abandoned.

ausi commented 3 years ago

tecnickcom/tcpdf is marked compatible with PHP >= 5.3 and I think the issues with PHP 8 seem to be mainly about deprecation notices.

I tested it manually on PHP 8.0.0 and the resulting PDF looked fine.

IMO this can be merged and released.

leofeyer commented 3 years ago

Thank you @ausi.