search

contao / website

Issue tracker for contao.org
2 stars 0 forks source link

Download link #106

Closed jonket55 closed 4 years ago

jonket55 commented 6 years ago

Download link on download page does not work in IE 11 or Edge.

xchs commented 6 years ago

I can also confirm that. The PHAR file opens in the browser instead of downloading.

leofeyer commented 6 years ago

We are sending the file as application/octet-stream, which should trigger the download dialog.

Maybe a bug in IE/Edge?

fritzmg commented 6 years ago

Zusätzlich muss vermutlich noch folgender response header mitgeschickt werden:

Content-Disposition: attachment; filename="contao-manager.phar"

Nur so teilt man dem Browser mit, dass die Datei immer zum runterladen ist. Andernfalls entscheidet es der Browser selbst - und bei octet-stream entscheidet der IE wohl anders als die anderen Browser.

xchs commented 6 years ago

entscheidet der IE wohl anders als die anderen Browser

Who's surprised? 😄

fritzmg commented 6 years ago

Who's surprised? 😄

It's not surprising, but in this case I'd argue that's it's not not surprising, because IE is horrible - but rather because the appropriate response header is missing ;). Without the header, the result is simply undefined (i.e. up to the client).

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.