FTX - Add order history endpoint

contek-io / io.contek.invoker

MIT License

39 stars 26 forks source link

FTX - Add order history endpoint #27

Closed oleksiilogvin closed 3 years ago

pimpcapital commented 3 years ago

Hi @oleksiilogvin . Thank you so much for your input. It is a very nice change. However, I am a bit concerned about the test part. We all agree testing is good, but I am not sure what is the best way to test private endpoints. Leaving placeholder fields for temporary test runs may result in an accidental commit that contains API Key secret.

What do you think?

oleksiilogvin commented 3 years ago

Hi @beijunyi, These are not actually placeholders but environment variable names, so you don't have to make a code change for passing the test. Just set env variables on test env: export FTX_API_KEY="your key" export FTX_API_SECRET="your sercet"