contentacms / contenta_react

Demo application written in React
http://react.contentacms.io/
38 stars 18 forks source link

Consider using superagent instead of axios for better JSON API support #4

Open spleshka opened 7 years ago

spleshka commented 7 years ago

I've noticed that devs at Lullabot use axios library for API calls to the backend. However, what we've found during the development for our clients, there is a great library which has awesome support for JSON API standard:

The last mentioned library provides really great DX for data processing which comes from D8 JSON API module:

yann-yinn commented 6 years ago

Interesting, for https://github.com/contentacms/contenta_vue_nuxt we used a combination of waterwheel + jsonapi-parse + axios. Maybe this could have been reduced to Waterwheel + SuperAgent-jsonapify ?

justafish commented 6 years ago

We can use the normal fetch API instead of either Axios or SuperAgent, with a polyfill for node https://www.npmjs.com/package/isomorphic-fetch

andrewfandrew commented 5 years ago

@justafish I am trying to develop this repo using the isomorphic-fetch method you recommend. I have today seen that spelshka (Evgeniy) has built a fully-fledged react demo app in a separate repo. But I want to continue development of your demo app. That is: based on create-react-app and isomorphic-fetch. I and my colleague are hoping to develop our React skills along the way. Please advise me on the best way i can contribute to this repo.