search

contentacms / contentajs

A nodejs server that proxies to Contenta CMS and holds custom code.
MIT License
102 stars 25 forks source link

NPM Script Missing in package.json - 'npm run stop' #21

Closed jacksonrya closed 5 years ago

jacksonrya commented 6 years ago

package.json is missing the script 'npm run stop' that would stop the pm2 process.

The installation instructions suggest this script exists. :)

e0ipso commented 6 years ago

Interesting. How would you imagine that works? Maybe pm2 delete all?

jacksonrya commented 5 years ago

I've been using pm2 delete contentajs to kill the app and it's current config, and then I use pm2 stop contentajs if I need to pause the processes for whatever reason, while keeping the current config. I don't know the necessity of referencing the app name, but it could be added safety if others are running non-contentajs pm2 processes?

e0ipso commented 5 years ago

@jacksonrya I think I agree and I'm going to go with the pm2 terminology, so it's clearer what the script is doing.

e0ipso commented 5 years ago

:tada: This issue has been resolved in version 0.19.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: