search

contentauth / c2pa-node

Node.js bindings for C2PA
MIT License
13 stars 10 forks source link

doesn't create deferred struct until we parse arguments #49

Closed dyro closed 8 months ago

dyro commented 8 months ago

The logs in provided to us by the reporter of the ticket included this error: 

neon::types::Deferred` was dropped without being settled

This occurs when a Deferred struct is created but not settled. Our code was creating the deferred values, then parsing arguments of the JS invocation of our APIs. If this parsing failed, the deffered value would never be settled, which causes the panic. The added test will fail if the deferred value is not settled.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 4c7754678cc66256b6ab04765cfcf50a7a07997c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------- | ----- | | c2pa-node | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR