Give a narrative description of what has been changed.
Previously, the Builder::add_resource method takes ownership of the resource stream. This is unnecessary and taking the stream as a reference allows for the stream to be used over and over again between calls (especially in long running processes).
The method also required the stream to be seekable, but this isn't necessary either as the stream is read into a memory buffer.
Checklist
[X] This PR represents a single feature, fix, or change.
[ ] All applicable changes have been documented.
[ ] Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.
Changes in this pull request
Give a narrative description of what has been changed.
Previously, the
Builder::add_resource
method takes ownership of the resource stream. This is unnecessary and taking the stream as a reference allows for the stream to be used over and over again between calls (especially in long running processes).The method also required the stream to be seekable, but this isn't necessary either as the stream is read into a memory buffer.
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.