search

contentauth / c2patool

Command line tool for displaying and adding C2PA manifests
Apache License 2.0
94 stars 30 forks source link

(IGNORE) Fix link to nightly build docs in README.md #142

Closed crandmck closed 9 months ago

crandmck commented 9 months ago

Changes in this pull request

Unfortunately, the relative link is broken when the doc is rendered on the doc site: https://opensource.contentauthenticity.org/docs/c2patool/#nightly-builds. Change to absolute URL fixes it.

Also added colon to UTC time, per Adobe style guide.

codecov-commenter commented 9 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (4996e42) 83.91% compared to head (091b426) 83.91%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ======================================= Coverage 83.91% 83.91% ======================================= Files 3 3 Lines 373 373 ======================================= Hits 313 313 Misses 60 60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crandmck commented 9 months ago

@scouten-adobe Your change still uses a relative URL. It needs to be an absolute URL for it to work from https://opensource.contentauthenticity.org/docs/c2patool/#nightly-builds which is the whole reason for this PR in the first place.

Also, wouldn't we always want to link to the file in the main branch? The main branch should always have the current/approved documentation; if there's a WIP branch, e.g. for a PR, then the link might temporarily go to the current README.md instead of the one in the branch, but that seems like an edge case that could easily be ignored during PR review.

Also, I don't have the ability to merge a PR in this repo, even if approved. :-(