search

contentco / quill-emoji

Quill module toolbar extension for emoji
275 stars 165 forks source link

Keyboard binding for ":" is not working for German keyboard Layout #131

Open siznjk opened 3 years ago

siznjk commented 3 years ago

Issue ":" key does not trigger smiley on German layout (possible others). I have looked a bit into the issue and it seems the English and German Layouts have different id's for : key. English id being "186" and German being "190". Moreover, trying to type "Ü" results in ":" (which now triggers smiley popup) for first character and "Ü" for the rest , which causes unpredictable behavior.

Expected ":" key should trigger smiley popup on any keyboard layout

Possible solution might lie with module-emoji.js by using event.keys from Quill.

christianhubmann commented 2 years ago

I can confirm that : does not trigger the popup on Chrome or Firefox with language German-Austria.

nicolasthy commented 2 years ago

Any update on this? The colon key is not the same on all keyboards and many of them do not require to hold Shift to write it 😕