search

contentco / quill-emoji

Quill module toolbar extension for emoji
274 stars 166 forks source link

scss error in angular environement #47 #53

Closed sumitvekariya closed 5 years ago

sumitvekariya commented 5 years ago

Relative Path to 'sheet_apple_64.png' is wrongly given.

CFT-Chris commented 5 years ago

No webpack errors with the current repo, but in your PR I get this build error:

ERROR in ./src/scss/quill-emoji.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleNotFoundError: Module not found: Error: Can't resolve './sheet_apple_64.png'

The relative path as it stands in repo looks logical to me, as the png is two subfolders down from its current location. The path should be agnostic to whatever external scss file imports or includes the file.

Any particular configuration you have that's causing your build error? Perhaps include it in the discussion in #56.

CFT-Chris commented 5 years ago

Closing this as #68 should address this.