contentco / quill-emoji

Quill module toolbar extension for emoji
275 stars 165 forks source link

radioactive vs radioactive_sign, wrong items in emoji list js #84

Open christopheroussy opened 5 years ago

christopheroussy commented 5 years ago

The copyright symbol also seems to be used multiple times (ap-radioactive, ap-biohazard) probably because of bem bem-radioactive ap ap-radioactive and .ap-radioactive_sign (notice how sign is present in once but absent in the other, no idea why), maybe this happened elsewhere ?

https://emojipedia.org/biohazard-sign/

Apple Name☣️ Biohazard

Unicode Name ☣️ Biohazard Sign

{
    "name": "radioactive", <-- sign missing ?
    "unicode": "2622",
    "shortname": ":radioactive:",
    "code_decimal": "&#9762;",
    "category": "s",
    "emoji_order": "2000"
  },
  {
    "name": "biohazard", <-- sign missing ?
    "unicode": "2623",
    "shortname": ":biohazard:",
    "code_decimal": "&#9763;",
    "category": "s",
    "emoji_order": "2001"
  },

There is a similar issue with .ap-heavy_heart_exclamation_mark_ornament and with bem bem-octagonal_sign ap ap-octagonal_sign it seems to fallback to the copyright sign.

Also by default you should provide icons with a less restrictive license ?

Those icons belong to apple, why use the apple stuff by default, it has a restrictive license.

Update 2018-02-06: According to Twitter posts, Apple has started enforcing that now in the App Store. Sam Eckert reports there: I’ve just been on the phone with the App Review team regarding the Emoji issue. Apps are NO LONGER ALLOWED TO USE EMOJI in non-keyboard based situations. Means if your app displays emoji anywhere without a user having it typed in, it’s illegal and will be rejected.