search

contentful-labs / Concorde

Download and decode progressive JPEGs on iOS.
MIT License
1.44k stars 152 forks source link

Moving the UI part to a separate subspec #16

Closed hfossli closed 8 years ago

hfossli commented 8 years ago

Keeping both Core and UI as default subspecs

hfossli commented 8 years ago

The Contentful subspec emits some warnings, but I don't think they got introduced now. 

➜  Concorde git:(master) ✗ pod lib lint

 -> Concorde (0.1.1)
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFNetworkReachabilityManager.m:111:17: warning: method override for the designated initializer of the superclass '-init' not found [-Wobjc-designated-initializers]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/usr/include/objc/NSObject.h:60:1: note: method marked as designated initializer of the class here
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFURLConnectionOperation.m:159:17: warning: method override for the designated initializer of the superclass '-init' not found [-Wobjc-designated-initializers]
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFURLSessionManager.m:319:62: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
    - WARN  | [Concorde/Contentful] xcodebuild:  AFNetworking/AFNetworking/AFURLSessionManager.m:319:92: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:85:73: warning: 'NSGregorianCalendar' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarIdentifierGregorian instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSLocale.h:115:36: note: 'NSGregorianCalendar' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:216:65: warning: 'NSYearCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitYear instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:65:2: note: 'NSYearCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:216:86: warning: 'NSMonthCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitMonth instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:66:2: note: 'NSMonthCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:216:108: warning: 'NSDayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitDay instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:67:2: note: 'NSDayCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:817:63: warning: 'NSYearCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitYear instead [-Wdeprecated-declarations]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:817:84: warning: 'NSWeekdayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitWeekday instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSCalendar.h:72:2: note: 'NSWeekdayCalendarUnit' has been explicitly marked deprecated here
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:817:108: warning: 'NSDayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitDay instead [-Wdeprecated-declarations]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:820:74: warning: 'NSYearCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitYear instead [-Wdeprecated-declarations]
    - WARN  | [Concorde/Contentful] xcodebuild:  ISO8601DateFormatter/ISO8601DateFormatter.m:823:70: warning: 'NSDayCalendarUnit' is deprecated: first deprecated in iOS 8.0 - Use NSCalendarUnitDay instead [-Wdeprecated-declarations]
    - NOTE  | [Concorde/Contentful] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/objc/NSObject.h:60:1: note: method marked as designated initializer of the class here

[!] Concorde did not pass validation, due to 13 warnings (but you can use `--allow-warnings` to ignore them).
neonichu commented 8 years ago

LGTM except for the one comment, thanks for the PR! The warnings were indeed there already.

hfossli commented 8 years ago

Even though the version number is unchanged, are you still able to publish the new version of the podspec? We don't support swift yet on our project you see.

neonichu commented 8 years ago

No, but I'll update the version number as part of my normal release workflow after this has been merged.

hfossli commented 8 years ago

Squashed

neonichu commented 8 years ago

Awesome, thanks for the contribution!