search

contentful-labs / starter-gatsby-blog

Gatsby starter for a Contentful project from the community.
https://contentful.github.io/starter-gatsby-blog/
MIT License
195 stars 199 forks source link

require the same node version as Gatsby #122

Closed axe312ger closed 3 years ago

axe312ger commented 4 years ago

As Gatsby requires Node 10 since Dec 2019, this starter should do so as well.

jo-sm commented 4 years ago

I think this makes sense -- could you also add an .nvmrc with the same version so that it's easy to go nvm use when in the repository, please?

This should also be able to close https://github.com/contentful/starter-gatsby-blog/issues/96 once this is merged.

axe312ger commented 4 years ago

@jo-sm added the nvmrc. Did not find a way to tell it "anything above 10.13", so I just use v10 which will use the installed node v10 which is pretty likely to be newer as 10.13

jo-sm commented 4 years ago

You can peg a specific version (for example, our .npmrc file is v10.15.3 in the app), but yeah I think you're right in that you can't peg to a version or higher. Since we can't, I think we should at least make the versions in package.json and .npmrc the same to prevent any possible weird edge cases that could happen.

axe312ger commented 4 years ago

@jo-sm I am pretty sure, if we fix it to a specific version number, it will require users downgrade their up2date v10 to v10.15.3 :(

jo-sm commented 4 years ago

That's a good point... and it's clear enough in the package.json file. Let's 🚢 it!