Replace HTTPoison with Tesla for flexibility

contentful-userland / contentful.ex

Elixir SDK for the Contentful Delivery API

MIT License

35 stars 30 forks source link

Replace HTTPoison with Tesla for flexibility #97

Closed OldhamMade closed 2 years ago

OldhamMade commented 3 years ago

Changes

Replace use of HTTPoison with Tesla
Update tests & fixtures to expect httpc as the base HTTP library (the default for Tesla)
Bump exvcr version

Resolves #96

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build cb61475a0e6a1c5473f3629c51cf78d57767e082-PR-97

6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 80.142%

Totals
Change from base Build 3506210596ec6f2ef7ac531d66519b6ae05dc4a3:	0.7%
Covered Lines:	113
Relevant Lines:	141

💛 - Coveralls

floriank commented 3 years ago

sorry for taking so long in reviewing this, I am a bit busy and moving the repo to contentful-userland has apparently changed notification settings.

Will try ASAP :)

floriank commented 3 years ago

@OldhamMade Could you rebase/merge latest master? :green_heart:

floriank commented 2 years ago

Thank you - this completely went under as I've been swamped with projects during work time and never received a notification for the status checks to pass (which seem to have hung themselves after the repo was moved to another organization)