contentful / apps

Apps on the Contentful Marketplace and resources to build them
https://contentful.com/marketplace
139 stars 148 forks source link

fix: add yargs as dev dependency for building functions [] #9186

Closed whitelisab closed 3 weeks ago

whitelisab commented 3 weeks ago

Purpose

Add yargs as a dev dependency for the app action function example, as yargs is used in the build-functions.js script. Previously this was working fine when the example was using react-scripts, and now since refactoring to vite, this was not working properly. When running npm run build, I was seeing this error: Cannot find module 'yargs/yargs'.

Approach

Testing steps

Breaking Changes

Dependencies and/or References

Deployment

netlify[bot] commented 3 weeks ago

Deploy Preview for ecommerce-app-base-components canceled.

Name Link
Latest commit 85b00bc4e9341648fe3d0b8e4027370445e6ff7d
Latest deploy log https://app.netlify.com/sites/ecommerce-app-base-components/deploys/6729452b9d67fd0008f75536