search

contentful / contentful-migration

🚚 Migration tooling for contentful
MIT License
325 stars 150 forks source link

makeRequest and dry run #648

Open florian-milky opened 3 years ago

florian-milky commented 3 years ago

Expected Behavior

makeRequest is executed when the migration has been validated and confirmed

Actual Behavior

makeRequest runs when the migration is validated

Possible Solution

Steps to Reproduce

  1. write a migration
  2. use makeRequest
  3. run the migration
  4. observe that makeRequest ran even though you still haven't chosen to apply the migration in the cli

Context

Environment

nteague22 commented 1 year ago

Yes, I even have looked at using the context and wiring up getClient, but having the migrations seed pass some form of flag even to allow for developer conditional execution would be helpful -- i.e. pass if it is committing the change or validating, so it is safe to run / does not have side effects