search

contentful / contentful.net

.NET Library for Contentful's Content Delivery and Management API
MIT License
95 stars 55 forks source link

Update TableCell Data field to be TableCellData object instead of GenericStructureData #330

Closed msm-agyemang closed 5 months ago

msm-agyemang commented 6 months ago

The TableCell class has a Data property which currently is of type GenericStructureData. This does not allow the rowspan and colspan fields from being serialized/deserialized from/to Contentful.

I can workaround writing by creating a TableCellData class that inherits from GenericStructureData but I can't deserialize.

If a TableCellData class can be created with these 2 properties and the TableCell.Data property updated to be of type TableCellData, then that should solve the problem

Roblinde commented 6 months ago

Ah interesting, I'll look into adding these. Thanks for the report.

msm-agyemang commented 5 months ago

Any updates on this? I could raise a PR for this if need be

Roblinde commented 5 months ago

@msm-agyemang a PR is always appreciated! I'm abroad a couple of days now, but hopefully I can have a look beginning of next week.

msm-agyemang commented 5 months ago

PR created https://github.com/contentful/contentful.net/pull/331

Roblinde commented 5 months ago

@msm-agyemang a new package was now released including these changes. Thanks for the contribution!