contentful / experience-builder

https://www.contentful.com/developers/docs/experiences/what-are-experiences/
MIT License
6 stars 1 forks source link

chore: publish packages to github npm registry [] #354

Closed Chaoste closed 3 months ago

Chaoste commented 3 months ago

In the web app, I'm not able to pull any version of core that was released in the last week. As we moved all private packages to npm.pkg.github.com, it looks like we need to move or public ones as well. According to the docs, .npmrc does only allow defining a registry per namespace. In the user interface, we point the whole Contentful namespace to npm.pkg.github.com which forces us to move experience-builder to this registry as well.

I hope that mirroring works correctly so that customers can still install via the npm registry. We already have a similar config for almost all our customer-facing packages - see code search. So I'm confident that this is the way to go.

Update

Ely and I aligned on this and cleared up all questions. All packages in the @contentful scope have to be on npm.pkg.github.com. We have a custom script that mirrors releases to npmjs once per hour.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **experience-builder-test-app** | ⬜️ Ignored ([Inspect](https://vercel.com/contentful-apps/experience-builder-test-app/HUCzLmizy9rrgdLkQiAjsz4548n9)) | | Feb 8, 2024 8:56pm |
elylucas commented 3 months ago

@Chaoste , why is this needed? All our packages are published to NPM and are publicly available.

SofiaMargariti commented 3 months ago

I see in some packages (forma36, rich-text) we have "access": "public",. Do we want the same here? If we don't include this, that means that customers can only install from npmjs and only we, internally, can install from GH registry, is that correct?

Chaoste commented 3 months ago

I see in some packages (forma36, rich-text) we have "access": "public",. Do we want the same here? If we don't include this, that means that customers can only install from npmjs and only we, internally, can install from GH registry, is that correct?

I checked the npm docs and they state that access is by default public. So that's why I left it out.

https://docs.npmjs.com/cli/v10/using-npm/config#access