search

contentful / experience-builder

https://www.contentful.com/developers/docs/experiences/what-are-experiences/
MIT License
5 stars 1 forks source link

[ALT-692] feat: update definitions of fill to use 100% for components #576

Closed ryunsong-contentful closed 3 weeks ago

ryunsong-contentful commented 4 weeks ago

Purpose

With the updates to the new input styles on Experiences canvas on the ui side, these fill values are no longer valid since the ui doesn't convert fill into a relative 100% option and is instead better to use the actual valid css value of 100%.

Note that in styleTransformers.ts this block of code was kept for backwards compatibility

// Keep this for backwards compatilibity - deleting this would be a breaking change
// because existing components on a users experience will have the width value as fill 
// rather than 100%
export const transformFill = (value?: string) => (value === 'fill' ? '100%' : value);
vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
experience-builder-test-app ✅ Ready (Inspect) Visit Preview Apr 22, 2024 3:43pm