search

contentful / experience-builder

https://www.contentful.com/developers/docs/experiences/what-are-experiences/
MIT License
5 stars 1 forks source link

fix(visual-editor): show hovered component outlines when hovering the layers tab [ALT-673] #584

Closed primeinteger closed 3 weeks ago

primeinteger commented 3 weeks ago

Purpose

This change revises the hoverComponent event to render the hover component outlines in the canvas when you are hovering over components in the layers tab.

Ticket: https://contentful.atlassian.net/browse/ALT-673

In this demo video, I start by hovering over components in the canvas, and then hover over components in the layers tab to show the same outlines being rendered in the canvas for both cases. Hover outlines are removed when moving the mouse to the "blank" area of the canvas or other parts of the UI.

https://github.com/contentful/experience-builder/assets/8539634/b6ddabe6-c08e-4e87-91aa-373b7cf89bba

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
experience-builder-test-app ✅ Ready (Inspect) Visit Preview Apr 25, 2024 9:02pm
primeinteger commented 3 weeks ago

Overall looks good to me. The only question I have is there's no way to get into a de-selected state in the Layers tab. I physically have to use the canvas for that. Probably a separate issue but could be a nice quick follow up or added in this PR where I can click in the white space of the layers tab and get into a clean de-selected mode. (This is probably a UI change rather than in EB)

That's exactly what https://github.com/contentful/user_interface/pull/20912 does!

chasepoirier commented 3 weeks ago

Looks great! Love seeing a net decrease in lines of code with this 🤌