contentful / extensions

Repository providing samples using the UI Extensions SDK
ISC License
204 stars 212 forks source link

removing extensions that were replaced by app functionality #287

Closed davidfateh closed 4 years ago

davidfateh commented 4 years ago

Removing extensions that have been replaced by app functionality.

suevalov commented 4 years ago

−224,132 nice contribution :)

are all deployed marketplace extensions/apps staying live?

codecov[bot] commented 4 years ago

Codecov Report

Merging #287 into master will increase coverage by 3.34%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   52.31%   55.65%   +3.34%     
==========================================
  Files         112       46      -66     
  Lines        2292      999    -1293     
  Branches      142      142              
==========================================
- Hits         1199      556     -643     
+ Misses       1066      416     -650     
  Partials       27       27
Flag Coverage Δ
#extensions 55.65% <ø> (+3.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7f4f45...6491d06. Read the comment docs.

hwartig commented 4 years ago

@suevalov and ~195500 lines of the 224000 removed lines came from package-lock.json files 😳so package-lock.json accounted for 87% of lines

davidfateh commented 4 years ago

are all deployed marketplace extensions/apps staying live?

@suevalov My guess is yes since I doubt there is a process to "unbuild" them automatically. I would also assume they will remain live at the last version they were deployed at.

I have kept a few apps which I know are potentially not migrated yet or are being used by 3rd parties.

kdamball commented 4 years ago

Are all extensions removed, not being used by 3rd parties?