search

contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

🐛 Bug - Forma 36 React - Tables that are not forma 36 components change colour on hover. #1451

Closed samgoulden28 closed 1 year ago

samgoulden28 commented 2 years ago

Forma 36 bug report

Summary

Hovering over any TD element in tables that are not forma 36 components changes their background color to white. This is particularly frustrating as I am attempting to build a contentful UI extension making use of the fullcalendar npm module.

Due to the rules:

tr:hover td:not(.TableCell__TableCell--head___3AHws){background-color:#f7f9fa}.

and

tr:hover td:not(.TableSortingLabel__TableCell--head___yxhXj){background-color:#f7f9fa}

Hovering over any TD element, even those that are not related to forma 36, will change their background color to #f7f9fa.

https://codesandbox.io/s/epic-mccarthy-yoezd?file=/src/App.js

Environment

"@contentful/forma-36-react-components": "^3.98.4",
"@contentful/forma-36-tokens": "^0.9.4",

Chrome Version 94.0.4606.81 (Official Build) (x86_64)

Steps to reproduce

See code sandbox https://codesandbox.io/s/epic-mccarthy-yoezd?file=/src/App.js

Expected results

I expect only forma 36 components to adhere to this css rule.

Actual results

I expected background colour of TDs not to change

denkristoffer commented 2 years ago

Thanks for reporting @samgoulden28, we will get this fixed.

Lelith commented 2 years ago

@denkristoffer is there still a fix planned for this or can we close this?

nawed2611 commented 2 years ago

Hey, Can I work on this issue?

denkristoffer commented 2 years ago

@nawed2611 Absolutely, that would be lovely 🙂

nawed2611 commented 2 years ago

I suppose this is the file that needs changing

nawed2611 commented 2 years ago

I'll create a PR for this

github-actions[bot] commented 1 year ago

Marking issue as stale since there was no acitivty for 30 days

denkristoffer commented 1 year ago

Although this bug is still valid I'll go ahead and close this issue as the v3 package is not maintained by Contentful anymore. We're still happy to accept external contributions for this issue though!