contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
331 stars 81 forks source link

build: switch to dual package emitting #2746

Closed cf-remylenoir closed 4 months ago

cf-remylenoir commented 4 months ago

Purpose of PR

[!NOTE] This is only for v5 alpha/beta pre-releases and won't be merged into main

Adds setup for emitting 2 package.json files for ESM and CJS, making use of tsconfig-to-dual-package.

This approach has the benefit of clearly declaring what type should be used since it relies on 2 package.json and prevents Node/TypeScript configuration confusion or change for the consumers, and mostly issues with our direct dependency for the icons (Phosphor)

Motivation and readings 🍿

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 2701795ca73be4713788f9b05b5bfd9823cd3bd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ❌ Failed (Inspect) May 8, 2024 2:54pm