Closed stephanLeece closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
forma-36 | ✅ Ready (Inspect) | Visit Preview | May 31, 2024 11:25am |
Latest commit: 5fec0ae9bc75430f2025a42be5050b2b54f97e10
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
CommonJS | 134.77 KB (0%) | 2.7 s (0%) | 113 ms (+60.27% 🔺) | 2.9 s |
Module | 131.19 KB (0%) | 2.7 s (0%) | 134 ms (+56.06% 🔺) | 2.8 s |
@stephanLeece I noticed that the last item in the breadcrumb lacks a margin. It should be the same as for the breadcrumb links.
Two tiny details in the documentation:
-36/assets/67584870/e0423f04-ad7b-4bf4-a21c-383a59ee9000">
Generally speaking, could you please also update the documentation to show the different variants: left, right, both sidebars, and full, wide, narrow?
Let me know if you have questions.
@stephanLeece I noticed that the last item in the breadcrumb lacks a margin. It should be the same as for the breadcrumb links.
![]()
Two tiny details in the documentation:
- the example content (form) has a padding. Ideally that would be removed.
- The background there is white. It should be gray/100
-36/assets/67584870/e0423f04-ad7b-4bf4-a21c-383a59ee9000"> Generally speaking, could you please also update the documentation to show the different variants: left, right, both sidebars, and full, wide, narrow?
Let me know if you have questions.
One thing regarding the background - i will add it for the example, but it's not part of the Layout
component itself. So we will need to add that background to the parent component when using Layout
in the web app.
@damann I've added examples with different sub components (Header, Sidebar, Both Sidebars)
I'm not sure i will be able to demonstrate what fullscreen / wide / narrow look like as the space to show the component in the example page is already at 628px. There's no space to render a wrapper with a background colour either.
I have demonstrated these in the storybook story though.
I think we are missing the spacing distribution / handling of the different elements mentioned in the ticket for the
narrow
variant.
I have the fixed 720px width set on the layout body for narrow variant. Spacing should be handled automatically. Is there something else missing?
I'm closing this for the next
branch: https://github.com/contentful/forma-36/tree/next, let's keep future work there.
Purpose of PR
Updates the Layout alpha component to the new
Modern and Scalable U.I
design.Tickets: https://contentful.atlassian.net/browse/CFISO-1472 https://contentful.atlassian.net/browse/CFISO-1520
wide
as it is more ...widely used.Full screen:![Screenshot 2024-05-14 at 17 22 28](https://github.com/contentful/forma-36/assets/32452823/54acb801-e4a8-40b1-836b-4b346a2592b7)
Wide:![Screenshot 2024-05-14 at 17 21 51](https://github.com/contentful/forma-36/assets/32452823/c04ecfa0-cca2-4666-8b57-05bd5a50a94e)
Narrow:![Screenshot 2024-05-14 at 17 22 51](https://github.com/contentful/forma-36/assets/32452823/804c9ef4-a3c8-4449-aa82-265f66d702a8)
PR Checklist
readme.md
file(s)