search

contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
331 stars 81 forks source link

fix: properly pass testId as data-test-id to components [] #2761

Closed massao closed 3 months ago

massao commented 3 months ago

Purpose of PR

We were passing the testId prop without renaming it, what would make tests that rely on the data-test-id to fail

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ❌ Failed (Inspect) May 17, 2024 0:05am
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 57a5b1de33ca3eca4c9cfad90c6cb78f66e1fe18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR