contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
331 stars 81 forks source link

feat(changesets): move avatar from alpha package to automatic release [AHOY-3166] #2764

Closed Annmary12 closed 3 months ago

Annmary12 commented 3 months ago

Purpose of PR

This PR moves Avatar from the alpha package to the automatic release.

PR Checklist

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1d247c39160efe4b88bf2fe2ec2f852309c33afc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages | Name | Type | | ---------------------------- | ----- | | @contentful/f36-components | Patch | | @contentful/f36-avatar | Patch | | @contentful/f36-image | Patch | | @contentful/f36-navbar | Patch | | @contentful/f36-accordion | Patch | | @contentful/f36-asset | Patch | | @contentful/f36-autocomplete | Patch | | @contentful/f36-badge | Patch | | @contentful/f36-button | Patch | | @contentful/f36-card | Patch | | @contentful/f36-collapse | Patch | | @contentful/f36-copybutton | Patch | | @contentful/f36-core | Patch | | @contentful/f36-datetime | Patch | | @contentful/f36-datepicker | Patch | | @contentful/f36-drag-handle | Patch | | @contentful/f36-entity-list | Patch | | @contentful/f36-empty-state | Patch | | @contentful/f36-forms | Patch | | @contentful/f36-icon | Patch | | @contentful/f36-list | Patch | | @contentful/f36-menu | Patch | | @contentful/f36-modal | Patch | | @contentful/f36-note | Patch | | @contentful/f36-notification | Patch | | @contentful/f36-pagination | Patch | | @contentful/f36-pill | Patch | | @contentful/f36-popover | Patch | | @contentful/f36-skeleton | Patch | | @contentful/f36-spinner | Patch | | @contentful/f36-table | Patch | | @contentful/f36-tabs | Patch | | @contentful/f36-text-link | Patch | | @contentful/f36-tooltip | Patch | | @contentful/f36-typography | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview May 23, 2024 1:03pm
github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 134.75 KB (+0.16% 🔺) 2.7 s (+0.16% 🔺) 83 ms (+75.82% 🔺) 2.8 s
Module 131.16 KB (+0.03% 🔺) 2.7 s (+0.03% 🔺) 85 ms (+99.69% 🔺) 2.8 s
denkristoffer commented 3 months ago

@Annmary12 Can you rebase on top of main?

@massao Can I ping you for review? Does this look right?

Annmary12 commented 3 months ago

You also need to:

  • Add the avatar to the f36-components package, as a dependency and as an export, also updating the example on how to import.
  • Also remove the alpha avatar from the SandpackRenderer.tsx, here
  • Remove from LiveEditor here
  • Add a changeset so it automatically updates the version to match the other packages and bump the versions.

I think that's it, but will take another look later again.

@Annmary12 can you just add a changeset, the last point, so the package get correctly release, we can do the other points in a follow up once we have a stable version of avatar release.

Done, please review