contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
331 stars 81 forks source link

refactor: pass color prop to icon from Button [CFISO-1471] #2766

Closed massao closed 3 months ago

massao commented 3 months ago

Purpose of PR

To enable usage of the Icons V5 alpha we need to pass the color prop from the Button to the Icons

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview May 28, 2024 8:14am
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 6f43954d537730dc2fd74fc76a4be5b2b85fe080

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages | Name | Type | | ---------------------------- | ----- | | @contentful/f36-button | Patch | | @contentful/f36-accordion | Patch | | @contentful/f36-asset | Patch | | @contentful/f36-autocomplete | Patch | | @contentful/f36-badge | Patch | | @contentful/f36-card | Patch | | @contentful/f36-collapse | Patch | | @contentful/f36-copybutton | Patch | | @contentful/f36-core | Patch | | @contentful/f36-datetime | Patch | | @contentful/f36-datepicker | Patch | | @contentful/f36-drag-handle | Patch | | @contentful/f36-entity-list | Patch | | @contentful/f36-empty-state | Patch | | @contentful/f36-forms | Patch | | @contentful/f36-icon | Patch | | @contentful/f36-list | Patch | | @contentful/f36-menu | Patch | | @contentful/f36-modal | Patch | | @contentful/f36-navbar | Patch | | @contentful/f36-note | Patch | | @contentful/f36-notification | Patch | | @contentful/f36-pagination | Patch | | @contentful/f36-pill | Patch | | @contentful/f36-popover | Patch | | @contentful/f36-skeleton | Patch | | @contentful/f36-spinner | Patch | | @contentful/f36-table | Patch | | @contentful/f36-tabs | Patch | | @contentful/f36-text-link | Patch | | @contentful/f36-tooltip | Patch | | @contentful/f36-typography | Patch | | @contentful/f36-components | Patch | | @contentful/f36-image | Patch | | @contentful/f36-avatar | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 134.77 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 99 ms (+65.91% 🔺) 2.8 s
Module 131.19 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 97 ms (+33.59% 🔺) 2.8 s