contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
331 stars 81 forks source link

fix(header): remove margin on noWrap #2771

Closed denkristoffer closed 3 months ago

denkristoffer commented 3 months ago

Purpose of PR

@massao the Header title has a left margin at the moment that we only want on elements that aren't the first child. Can we safely remove it from the noWrap class?

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview May 29, 2024 3:04pm
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 96d22d38758e933eb8c8c2369953fb2180b83bb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 134.77 KB (0%) 2.7 s (0%) 97 ms (+121.16% 🔺) 2.8 s
Module 131.19 KB (0%) 2.7 s (0%) 97 ms (+98.1% 🔺) 2.8 s
denkristoffer commented 3 months ago

Nope, checked the UI tests, it doesn't work. We want the margin when there's a separator, but not when the title is on its own.