Closed stephanLeece closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
forma-36 | ✅ Ready (Inspect) | Visit Preview | Jun 4, 2024 11:23am |
Latest commit: f5b4bafd1d00e3b6477c9fd7160e11082a58b4d2
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
CommonJS | 134.77 KB (0%) | 2.7 s (0%) | 98 ms (+61.46% 🔺) | 2.8 s |
Module | 131.19 KB (0%) | 2.7 s (0%) | 101 ms (+35.54% 🔺) | 2.8 s |
Let me know what the release process for this should be. Would the next Header package version be "4.0.0-alpha.8"
?
I assume it should still be merged into main, should that happen before or after the new Header package version is published?
Let me know what the release process for this should be. Would the next Header package version be
"4.0.0-alpha.8"
?I assume it should still be merged into main, should that happen before or after the new Header package version is published?
Yes, the version should be 4.0.0-alpha.8
, and you should publish it before merging, since it needs to have the version on the package.json updated.
For release, since we don't have setup for releasing prereleases automatically, you would need to release it manually, there is a npm run prerelease
script that should help with it, just remember to run npm run build
before the release, to avoid releasing the version with the old build
ughh.. published as 4.0.0-alpha.9 due to connection issues and me being too quick to hammer the retry button without reverting the change in package.json first.
If that's a big no no, is it possible to unpublish and then republish as the correct version number?
ughh.. published as 4.0.0-alpha.9 due to connection issues and me being too quick to hammer the retry button without reverting the change in package.json first.
If that's a big no no, is it possible to unpublish and then republish as the correct version number?
No worries, specially being alpha version, we just skipped the .8
😄
Do you want to bring this component out of alpha for v4?
Sure, would we move it to beta? so 4.0.0-beta.0
?
Sure, would we move it to beta? so
4.0.0-beta.0
?
No just a stable component at this point. I don't think we are going to do much more with it for v4.
Sounds good, anything i need to keep in mind when moving a component to a stable release? I guess:
@stephanLeece We need docs on the website, but we have that: https://forma-36-git-cfiso-1571-update-header-left-margin.colorfuldemo.com/components/header – the "Alpha" badge should be removed though. Your list is correct, but you should also add it to the array with fixed versions in the changeset config. Regarding the version, you can set it to 4.0.0 and the release script should do the rest.
@allcontributors add @stephanLeece for code, maintenance
@denkristoffer
I've put up a pull request to add @stephanLeece! :tada:
@stephanLeece We need docs on the website, but we have that: https://forma-36-git-cfiso-1571-update-header-left-margin.colorfuldemo.com/components/header – the "Alpha" badge should be removed though. Your list is correct, but you should also add it to the array with fixed versions in the changeset config. Regarding the version, you can set it to 4.0.0 and the release script should do the rest.
Done! If all looks good now, I'll go ahead and merge :)
Closing this due to circleCi issues, will reopen with requested changes
Purpose of PR
Left margin on Header’s title prop is no longer rendered when there’s no element to the left of the title
I updated the
noWrap
class styling so that the margin is only applied if the element is not first-child. This follows the existing approach we use for thetitle
classI had done something similar when working on the Updated Layout component, in this commit.
Tickets: https://contentful.atlassian.net/browse/CFISO-1571
PR Checklist
readme.md
file(s)