Closed andipaetzold closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
forma-36 | ✅ Ready (Inspect) | Visit Preview | Jun 6, 2024 7:57am |
Latest commit: 145b5958e0cf10d0598e5c43108fe54e78f405ed
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
CommonJS | 135.73 KB (+0.02% 🔺) | 2.8 s (+0.02% 🔺) | 119 ms (+101.13% 🔺) | 2.9 s |
Module | 132.07 KB (+0.02% 🔺) | 2.7 s (+0.02% 🔺) | 115 ms (+77.51% 🔺) | 2.8 s |
Purpose of PR
It's currently not possible to know when all Modal have been closed after
ModalLauncher.closeAll()
. Due to close delays and the async implementation, Modals may still be open afterModalLauncher.closeAll()
is called.This PR makes the function async and resolve when all Modals are closed. This changes the return type and could therefore cause typescript issues in projects using F36.
PR Checklist
readme.md
file(s)