contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

feat(ModalLauncher): wait for Modals to be closed #2780

Closed andipaetzold closed 1 month ago

andipaetzold commented 1 month ago

Purpose of PR

It's currently not possible to know when all Modal have been closed after ModalLauncher.closeAll(). Due to close delays and the async implementation, Modals may still be open after ModalLauncher.closeAll() is called.

This PR makes the function async and resolve when all Modals are closed. This changes the return type and could therefore cause typescript issues in projects using F36.

PR Checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jun 6, 2024 7:57am
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 145b5958e0cf10d0598e5c43108fe54e78f405ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ---------------------------- | ----- | | @contentful/f36-modal | Minor | | @contentful/f36-accordion | Minor | | @contentful/f36-asset | Minor | | @contentful/f36-autocomplete | Minor | | @contentful/f36-badge | Minor | | @contentful/f36-button | Minor | | @contentful/f36-card | Minor | | @contentful/f36-collapse | Minor | | @contentful/f36-copybutton | Minor | | @contentful/f36-core | Minor | | @contentful/f36-datetime | Minor | | @contentful/f36-datepicker | Minor | | @contentful/f36-drag-handle | Minor | | @contentful/f36-entity-list | Minor | | @contentful/f36-empty-state | Minor | | @contentful/f36-forms | Minor | | @contentful/f36-icon | Minor | | @contentful/f36-header | Minor | | @contentful/f36-list | Minor | | @contentful/f36-menu | Minor | | @contentful/f36-navbar | Minor | | @contentful/f36-note | Minor | | @contentful/f36-notification | Minor | | @contentful/f36-pagination | Minor | | @contentful/f36-pill | Minor | | @contentful/f36-popover | Minor | | @contentful/f36-skeleton | Minor | | @contentful/f36-spinner | Minor | | @contentful/f36-table | Minor | | @contentful/f36-tabs | Minor | | @contentful/f36-text-link | Minor | | @contentful/f36-tooltip | Minor | | @contentful/f36-typography | Minor | | @contentful/f36-components | Minor | | @contentful/f36-image | Minor | | @contentful/f36-avatar | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 135.73 KB (+0.02% 🔺) 2.8 s (+0.02% 🔺) 119 ms (+101.13% 🔺) 2.9 s
Module 132.07 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 115 ms (+77.51% 🔺) 2.8 s