contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

feat: update navigation item style #2783

Closed cf-remylenoir closed 1 month ago

cf-remylenoir commented 1 month ago

Purpose of PR

Updates the navigtion item style for further work on navigation.

Screenshot 2024-06-07 at 14 56 57

PR Checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ❌ Failed (Inspect) Jun 7, 2024 3:40pm
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: b79a7bbd87f6ac58d2072d28215e3541c465f6b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

denkristoffer commented 1 month ago

There's a bit of shift when switching between items, probably because of the border.

We need some more spacing between items to avoid selected and hovered items touching.

Screenshot 2024-06-06 at 17 38 31

@damann

cf-remylenoir commented 1 month ago

There's a bit of shift when switching between items, probably because of the border.

We need some more spacing between items to avoid selected and hovered items touching. Screenshot 2024-06-06 at 17 38 31

@damann

Yes, I noticed too. My work is solely for the item styling, I figured @Lelith would make structural changes to the navigation in her branch so this will be corrected.

But I am happy to apply the gap change in my branch, wdyt @Lelith ?

cf-remylenoir commented 1 month ago

There's a bit of shift when switching between items, probably because of the border. We need some more spacing between items to avoid selected and hovered items touching. Screenshot 2024-06-06 at 17 38 31 @damann

Yes, I noticed too. My work is solely for the item styling, I figured @Lelith would make structural changes to the navigation in her branch so this will be corrected.

But I am happy to apply the gap change in my branch, wdyt @Lelith ?

I added the gap to the navigation 👍

Screenshot 2024-06-07 at 14 56 57