contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

feat(AssetCard): support for providing a custom badge #2784

Closed chrishelgert closed 1 month ago

chrishelgert commented 1 month ago

Purpose of PR

The EntryCard supports providing a custom badge, the AssetCard don't do that yet. This PR introduces the custom badge for the AssetCard too, to have the same behaviour and experience.

PR Checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jun 10, 2024 11:48am
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 439c69ec119980c10ed19bf32fe33ceea3305714

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ---------------------------- | ----- | | @contentful/f36-card | Minor | | @contentful/f36-accordion | Minor | | @contentful/f36-asset | Minor | | @contentful/f36-autocomplete | Minor | | @contentful/f36-badge | Minor | | @contentful/f36-button | Minor | | @contentful/f36-collapse | Minor | | @contentful/f36-copybutton | Minor | | @contentful/f36-core | Minor | | @contentful/f36-datetime | Minor | | @contentful/f36-datepicker | Minor | | @contentful/f36-drag-handle | Minor | | @contentful/f36-entity-list | Minor | | @contentful/f36-empty-state | Minor | | @contentful/f36-forms | Minor | | @contentful/f36-icon | Minor | | @contentful/f36-header | Minor | | @contentful/f36-list | Minor | | @contentful/f36-menu | Minor | | @contentful/f36-modal | Minor | | @contentful/f36-navbar | Minor | | @contentful/f36-note | Minor | | @contentful/f36-notification | Minor | | @contentful/f36-pagination | Minor | | @contentful/f36-pill | Minor | | @contentful/f36-popover | Minor | | @contentful/f36-skeleton | Minor | | @contentful/f36-spinner | Minor | | @contentful/f36-table | Minor | | @contentful/f36-tabs | Minor | | @contentful/f36-text-link | Minor | | @contentful/f36-tooltip | Minor | | @contentful/f36-typography | Minor | | @contentful/f36-components | Minor | | @contentful/f36-image | Minor | | @contentful/f36-avatar | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 135.74 KB (+0.01% 🔺) 2.8 s (+0.01% 🔺) 853 ms (-12.38% 🔽) 3.6 s
Module 132.08 KB (+0.01% 🔺) 2.7 s (+0.01% 🔺) 951 ms (-8.7% 🔽) 3.6 s
denkristoffer commented 1 month ago

@damann would you mind reviewing this one?

cf-remylenoir commented 1 month ago

@all-contributors please add @chrishelgert for code and doc.

allcontributors[bot] commented 1 month ago

@cf-remylenoir

I've put up a pull request to add @chrishelgert! :tada: