contentful / forma-36

A design system by Contentful

https://f36.contentful.com

MIT License

329 stars 81 forks source link

feat: single line navigation #2785

Closed Lelith closed 1 month ago

Lelith commented 1 month ago

Purpose of PR

reduce the size and structure of the Navbar to a single-line. It contains the following breaking changes:

removal of Components NavbarSearch and NavbarHelp
Prop change of NavbarItem:
- title is no longer required
- accepts new property label which will be set as aria-label for Items without a title
Prop changes of Navbar
- removes the following props:
- badge
- bottomRightItems
- children
- help
- search
- topRightItems
- introduces new props
- mainNav as replacement for children
- secondaryNav as a replacement for the other removed properties

Screenshots:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
forma-36	❌ Failed (Inspect)		Jun 10, 2024 1:19pm

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 95f6183bd561c61358184e74e64ae5309ed0b656

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cf-remylenoir commented 1 month ago

Not related to your changes but I noticed we have an a11y issue with the account button.

Storybook a11y highlight

damann commented 1 month ago

Does that mean the Avatar component has the same issues? Or is it only in the navigation?

Not related to your changes but I noticed we have an a11y issue with the account button.

cf-remylenoir commented 1 month ago

Does that mean the Avatar component has the same issues? Or is it only in the navigation?

Not related to your changes but I noticed we have an a11y issue with the account button.

Only in the navigation where we wrap the avatar with a button to display the account settings.