contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

chore: exclude react-day-picker.js.org from link check #2806

Closed denkristoffer closed 1 month ago

denkristoffer commented 1 month ago

Purpose of PR

Exclude https://react-day-picker.js.org/ from the link checker job.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jun 24, 2024 3:20pm
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 52834b128b790bc3d76bd1ec8442e4056ee5b2ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 135.79 KB (0%) 2.8 s (0%) 95 ms (+50.53% 🔺) 2.9 s
Module 132.05 KB (0%) 2.7 s (0%) 83 ms (+16.16% 🔺) 2.8 s
stephanLeece commented 1 month ago

I'm happy to go with this approach and just exclude the links, but you may wanna run this by @andipaetzold first as it looks like his changes just updated the broken links rather than excluding them from the checks. So perhaps there's some benefit of keeping the checks in that I'm unaware of...

denkristoffer commented 1 month ago

I'm happy to go with this approach and just exclude the links, but you may wanna run this by @andipaetzold first as it looks like his changes just updated the broken links rather than excluding them from the checks. So perhaps there's some benefit of keeping the checks in that I'm unaware of...

Good point, seems like the website actually changed. It redirects to https://daypicker.dev/ now. Closed for #2807