contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

fix: navbar switcher colour #2809

Closed denkristoffer closed 1 month ago

denkristoffer commented 1 month ago

Purpose of PR

Small visual tweaks to the switcher button.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 8f58f0617ee6aa92f93e6ef17550aee11c8b43a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jun 25, 2024 11:15am
github-actions[bot] commented 1 month ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 135.84 KB (+0.05% 🔺) 2.8 s (+0.05% 🔺) 101 ms (+71.78% 🔺) 2.9 s
Module 132.05 KB (0%) 2.7 s (0%) 121 ms (+68.63% 🔺) 2.8 s
denkristoffer commented 1 month ago

LGTM, why is chromatic showing so many changes though? 🤔

@massao I'm not certain but I think Chromatic is comparing against main? I changed the Storybook render wrapper a bit on the light navigation branch to be able to change viewport width all the way down, we had a set min-width before.