search

contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
329 stars 81 forks source link

feat: increase hit area for navigation buttons [CFISO-1555] #2810

Closed massao closed 1 month ago

massao commented 1 month ago

Purpose of PR

Increases the hit area on navigation buttons

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: ec71cca5d72b5e9e09f46adc7dfc253c32eb36ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jun 25, 2024 2:04pm
denkristoffer commented 1 month ago

The focus ring on the account avatar is slightly cropped on the top and bottom

Screenshot 2024-06-25 at 15 21 45
massao commented 1 month ago

The focus ring on the account avatar is slightly cropped on the top and bottom Screenshot 2024-06-25 at 15 21 45

Did this happen in a specific browser?? I tested in some and it looks fine 🤔

image
denkristoffer commented 1 month ago

Did this happen in a specific browser?? I tested in some and it looks fine 🤔 image

FF 🦊

massao commented 1 month ago

FF 🦊

Doesn't happen to me 🤔

image

No idea what can be happening 😬

cf-remylenoir commented 1 month ago

I have no issues with the account focus ring, it works on all browsers 👍

Could you please add a story for the mobile view or see if we can fix the Storybook viewport feature? I tried using the Storybook viewport feature to get the responsiveness but it does not seem to work 🤔

Screenshot 2024-06-25 at 15 52 41
massao commented 1 month ago

Could you please add a story for the mobile view or see if we can fix the Storybook viewport feature? I tried using the Storybook viewport feature to get the responsiveness but it does not seem to work 🤔

@cf-remylenoir I separated the PRs, because we may want to merge the hitarea first, the other PR (https://github.com/contentful/forma-36/pull/2805), the complete Story has a fullscreen layout that should work with the resize of the window/storybook

cf-remylenoir commented 1 month ago

Could you please add a story for the mobile view or see if we can fix the Storybook viewport feature? I tried using the Storybook viewport feature to get the responsiveness but it does not seem to work 🤔

@cf-remylenoir I separated the PRs, because we may want to merge the hitarea first, the other PR (#2805), the complete Story has a fullscreen layout that should work with the resize of the window/storybook

I got mixed up between the two PRs 😄