contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
335 stars 81 forks source link

fix: adjust spacing and button size #2848

Closed Lelith closed 2 months ago

Lelith commented 2 months ago

Purpose of PR

adjusts width of buttons as well as spacing between secondary navigation buttons before:

image

after:

image
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Aug 22, 2024 5:59am
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 22019d12f4b886d7af33c90897886ed5d5dd991f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. ```
Lelith commented 2 months ago

Are we planning to increase button sizes on small devices?

the clickable area is increased on all screens (and is 44x44). On smaller screens the secondary menu is hidden.