contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
335 stars 81 forks source link

feat: add environment to navbar switcher #2857

Closed massao closed 2 months ago

massao commented 2 months ago

Purpose of PR

Add environment name to the navbar switcher

Preview

image
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Sep 6, 2024 3:37pm
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 5b5c5d4b61e8798ab4ed965fffb0b93bec945f37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. ```
damann commented 2 months ago

It looks good to me, my only remark would be related to the poor contrast of the caret icon color with its background. @damann what do you think, does it satisfy an accessible contrast ratio?

Let's bump it up to grey500 (contrast ratio 4.57:1)