contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
335 stars 81 forks source link

feat: updates avatar design and variations #2858

Closed Lelith closed 2 months ago

Lelith commented 2 months ago

What changed?

Screenshots

image
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Sep 12, 2024 8:11am
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 03a97242aeb31192e1b7f77e49fa48bf110d2a95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages | Name | Type | | ---------------------------- | ----- | | @contentful/f36-avatar | Minor | | @contentful/f36-components | Minor | | @contentful/f36-navbar | Minor | | @contentful/f36-accordion | Minor | | @contentful/f36-asset | Minor | | @contentful/f36-autocomplete | Minor | | @contentful/f36-badge | Minor | | @contentful/f36-button | Minor | | @contentful/f36-card | Minor | | @contentful/f36-collapse | Minor | | @contentful/f36-copybutton | Minor | | @contentful/f36-core | Minor | | @contentful/f36-datetime | Minor | | @contentful/f36-datepicker | Minor | | @contentful/f36-drag-handle | Minor | | @contentful/f36-entity-list | Minor | | @contentful/f36-empty-state | Minor | | @contentful/f36-forms | Minor | | @contentful/f36-icon | Minor | | @contentful/f36-header | Minor | | @contentful/f36-list | Minor | | @contentful/f36-menu | Minor | | @contentful/f36-modal | Minor | | @contentful/f36-note | Minor | | @contentful/f36-notification | Minor | | @contentful/f36-pagination | Minor | | @contentful/f36-pill | Minor | | @contentful/f36-popover | Minor | | @contentful/f36-skeleton | Minor | | @contentful/f36-spinner | Minor | | @contentful/f36-table | Minor | | @contentful/f36-tabs | Minor | | @contentful/f36-text-link | Minor | | @contentful/f36-tooltip | Minor | | @contentful/f36-typography | Minor | | @contentful/f36-image | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 111.8 KB (-0.16% 🔽) 2.3 s (-0.16% 🔽) 1.3 s (+2.57% 🔺) 3.5 s
Module 110.74 KB (+0.1% 🔺) 2.3 s (+0.1% 🔺) 1.5 s (+6.41% 🔺) 3.7 s
damann commented 2 months ago

Tiny muted doesn't have a border

Why did we decide to remove the border from tiny? FWIW I'm thinking about removing the tiny variant all together (in a follow up).

andipaetzold commented 2 months ago

Tiny muted doesn't have a border

Why did we decide to remove the border from tiny? FWIW I'm thinking about removing the tiny variant all together (in a follow up).

@damann I followed the provided designs. But I think that aspect was only temporary. I'll re-add the border.

damann commented 2 months ago

@damann I followed the provided designs. But I think that aspect was only temporary. I'll re-add the border.

@andipaetzold My apologies, I didn't prepare the avatar component diligently enough. I hate causing double work, especially if it's a mundane task such as this.