search

contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
331 stars 81 forks source link

fix: add fixed height to navbar #2862

Closed Lelith closed 5 days ago

Lelith commented 1 week ago

this pr is related to https://github.com/contentful/forma-36/pull/2859 it adds a fixed height to the light navbar and exports it, so it is useable in other components

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ❌ Failed (Inspect) Sep 11, 2024 6:59am
changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: c424e3c150c537a3df72a1097923058766667495

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. ```
andipaetzold commented 1 week ago

Just to confirm: This doesn't change how things look, but only adds a height to ensure the height will stay at 60px.