search

contentful / forma-36

A design system by Contentful
https://f36.contentful.com
MIT License
335 stars 81 forks source link

refactor: enable children on navbar switcher #2863

Closed massao closed 2 months ago

massao commented 2 months ago

Purpose of PR

In some use cases we don't have space and environment, in those cases we pass a string that will appear on the switcher

Preview

image
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Sep 9, 2024 0:27am
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: f2fb6597c29749ea5ed6cfcc74d7f09d6ec36bea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR ``` Some errors occurred when validating the changesets config: The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option. ```
damann commented 2 months ago

Hey Massao, I strongly recommend removing that behavior as it’s a bit misleading. The label 'Account Settings' should be shown in the page header. I'm working on a proposal that will eliminate the need to change the main navigation for different settings areas (org, space, account). In the meantime, I suggest we use the breadcrumb in the header to display the 'Account Settings' label and remove it from the main navigation.

Lelith commented 2 months ago

@damann the string is not hardcoded in there, it only allows us to also hand over strings.

damann commented 2 months ago

@damann the string is not hardcoded in there, it only allows us to also hand over strings.

Thanks. That’s fine, but there shouldn’t be any text in that place that resembles the environment switcher. I hadn’t specified this earlier as I only came across it recently, and it got buried under other priorities 🙇. As mentioned, I’m working on a better alternative, but for now, the interim solution should be to remove or hide it.