Upgrade videojs to v7 - Githubissues

contently / videojs-annotation-comments

A plugin for video.js to add support for timeline moment/range comments and annotations

https://contently.github.io/videojs-annotation-comments/

Other

171 stars 50 forks source link

Upgrade videojs to v7 #49

Closed jackpope closed 4 years ago

jackpope commented 5 years ago

Fixes #46

Move to yarn for package management
Upgrade videojs to v7.6.0 https://github.com/contently/videojs-annotation-comments/issues/46
Update Circle ci config to use node 10.15.2
Fixes gulp build from no-oping
Add semantic-release git
Remove build files from version control

aaackerman commented 4 years ago

@jackpope do you need any eyes on new changes or help wrt testing?

jackpope commented 4 years ago

@aaackerman I should have some time tomorrow to look this over again and fix the dev watch command. I'll re-request your review when it is ready for another look. Thanks!

drichar commented 4 years ago

We're using videojs v7 and evaluating this for our core product. It looks to be exactly what we need. Let us know if we can help to get it merged!

contentlyrobot commented 4 years ago

:tada: This PR is included in version 1.1.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

drichar commented 4 years ago

Thank you!! 🎉🎉

jackpope commented 4 years ago

@drichar just a note on this release, somehow my BREAKING CHANGE commit messages didn't get picked up by semantic-release. I'm trying to move things around to get this out at v2.0.0 as there are breaking changes. Will update here when done.

jackpope commented 4 years ago

I've published v2.0.0 to npm and tagged here on github.

The v1.1.5 release has been removed.

Cheers! :champagne: