search

contently / videojs-annotation-comments

A plugin for video.js to add support for timeline moment/range comments and annotations
https://contently.github.io/videojs-annotation-comments/
Other
171 stars 50 forks source link

Edit ranged marker on progress bar #60

Open vanlinha3k35pbc opened 4 years ago

vanlinha3k35pbc commented 4 years ago

Description

I want to add ranged marker on progress bar which has:

  1. Start and end point dragable (in case editing marker) on progress bar when clicked.
  2. Action trigger after dragging start/end point
  3. Color can be customize

Question

a. It is possible to having 1,2 when adding new annotation. But I can not edit annotation. Is there something I miss out? b. Is 3 possible (eg. adding custom class for annotation)

Additional Information

versions

    "@contently/videojs-annotation-comments": "^2.0.1",
    "imports-loader": "^0.8.0",
    "jquery": "^3.4.1",
    "video.js": "^7.6.6"

browsers

Currently using Chrome, also experienced on Firefox

OS

Windows 10

Demo repo

https://github.com/vanlinha3k35pbc/progress-bar-marker-demo

jackpope commented 4 years ago

Hi @vanlinha3k35pbc

There currently is no support for editing annotations. The use-cases that have come up so far are solved by deleting and re-creating annotations that may have been added incorrectly. Editing/updating could be useful to some though -- would be great to see a PR for the support 😄

For global customization, you can add styling to the build in classes: .vac-marker, .vac-marker-draggable. Is the idea to add a custom class per marker? How would you expect that you be configured or the data passed in?